New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): include new iphone models into os extension #11212
Conversation
|
// iPhone 11 Pro | ||
'iPhone12,3': [ 'Apple A13 Bionic @ 2.66 GHz', 2660 ], | ||
// iPhone 11 | ||
'iPhone12,1': [ 'Apple A13 Bionic @ 2.66 GHz', 2660 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am insane, and had to run this in the sims to verify because all the normal wiki/web sites don't actually have this info up. But your module numbers look accurate (at least against the simulators).
As for the CPU speeds... are you guessing? I cannot seem to find any reliable info on them at all. I've seen a projection of 2.9GHz (which I think is way too high), and another of 2.65GHz (which seems like it's in the correct ballpark, though still may be too high)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did take a little searching to find this info, I used a Geekbench result to determine the frequency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks Gary!
os
extensioncpuModelAndSpeed
from failingios.os.#cpus() returns array of objects whose length matches Ti.Platform.processorCount
test caseTEST CASE
JIRA Ticket