Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): include new iphone models into os extension #11212

Merged
merged 2 commits into from Sep 12, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Sep 11, 2019

  • Include new iPhone models into os extension
  • Prevent cpuModelAndSpeed from failing
  • Fixes ios.os.#cpus() returns array of objects whose length matches Ti.Platform.processorCount test case
TEST CASE
const os = require('os');
console.log(JSON.stringify(os.cpus(), 1));

JIRA Ticket

@build
Copy link
Contributor

build commented Sep 12, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 81840e4

// iPhone 11 Pro
'iPhone12,3': [ 'Apple A13 Bionic @ 2.66 GHz', 2660 ],
// iPhone 11
'iPhone12,1': [ 'Apple A13 Bionic @ 2.66 GHz', 2660 ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am insane, and had to run this in the sims to verify because all the normal wiki/web sites don't actually have this info up. But your module numbers look accurate (at least against the simulators).

As for the CPU speeds... are you guessing? I cannot seem to find any reliable info on them at all. I've seen a projection of 2.9GHz (which I think is way too high), and another of 2.65GHz (which seems like it's in the correct ballpark, though still may be too high)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did take a little searching to find this info, I used a Geekbench result to determine the frequency.

@sgtcoolguy sgtcoolguy self-requested a review September 12, 2019 17:29
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Gary!

@sgtcoolguy sgtcoolguy merged commit b3a720a into tidev:master Sep 12, 2019
sgtcoolguy pushed a commit that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants