fix(ios): also lookup semnantic colors in correct location for classic #11217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's intended to be cross platform this is the right place for a classic app Fixes TIMOB-27403
|
ssjsamir
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
FR Passed: The look up for semantic lookup now works correctly. Tested with the test steps mentioned in: https://jira.appcelerator.org/browse/TIMOB-27403
Test Environment
MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 7 (13.0 GM)
"NPM":"4.2.15","CLI":"7.1.1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's intended to be cross platform this is the right place for a classic app
Fixes TIMOB-27403
JIRA: https://jira.appcelerator.org/browse/TIMOB-27403