New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): also lookup semnantic colors in correct location for classic (8_2_X) #11218
Conversation
As it's intended to be cross platform this is the right place for a classic app Fixes TIMOB-27403
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: The look up for semantic lookup now works correctly. Tested with the test steps mentioned in: https://jira.appcelerator.org/browse/TIMOB-27403
Test Environment
MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 7 (13.0 GM)
"NPM":"4.2.15","CLI":"7.1.1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
This is still not working for me. Please check this below code snippet and correct me If I am missing something.
semantic.colors.json file content:
App Folder structure:
|
@KamalKant-Tech, you code is working fine for me on SDK 9.0.3.GA. This fix shipped in 8.2.1.GA so please make sure you're using the correct SDK |
Thats working. Sorry I did not update it here. |
As it's intended to be cross platform this is the right place for a classic app
Fixes TIMOB-27403
JIRA: https://jira.appcelerator.org/browse/TIMOB-27403
Backport for #11217