Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): also lookup semnantic colors in correct location for classic (8_2_X) #11218

Merged
merged 1 commit into from Sep 20, 2019

Conversation

ewanharris
Copy link
Collaborator

As it's intended to be cross platform this is the right place for a classic app

Fixes TIMOB-27403

JIRA: https://jira.appcelerator.org/browse/TIMOB-27403

Backport for #11217

As it's intended to be cross platform this is the right place for a classic app

Fixes TIMOB-27403
@build build added this to the 8.2.0 milestone Sep 16, 2019
@build
Copy link
Contributor

build commented Sep 16, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against a695fda

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: The look up for semantic lookup now works correctly. Tested with the test steps mentioned in: https://jira.appcelerator.org/browse/TIMOB-27403

Test Environment

MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 7 (13.0 GM)
"NPM":"4.2.15","CLI":"7.1.1"

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@vijaysingh-axway vijaysingh-axway modified the milestones: 8.2.0, 8.2.1 Sep 16, 2019
@sgtcoolguy sgtcoolguy merged commit df39a91 into tidev:8_2_X Sep 20, 2019
@KamalKant-Tech
Copy link

KamalKant-Tech commented Aug 14, 2020

This is still not working for me. Please check this below code snippet and correct me If I am missing something.

var colorWindow = Ti.UI.fetchSemanticColor("backgroundColor");


var win = Ti.UI.createWindow({
    title: 'Demo App',
    backgroundColor: colorWindow,
    layout: 'vertical'
});
var view = Ti.UI.createView({
    center: { x: 205, y: 250 },
    height: 400,
    width: 300,
    backgroundColor: colorWindow,
    layout: 'vertical',
    top: '20%'
});

win.add(view);
win.open();

semantic.colors.json file content:

{
  "backgroundColor": {
    "light": "#E32121",
    "dark": "#000000"
  }
}

App Folder structure:

Resource > app.js
Resource > semantic.colors.json

@ewanharris ewanharris deleted the TIMOB-2740382X branch August 14, 2020 10:02
@ewanharris
Copy link
Collaborator Author

@KamalKant-Tech, you code is working fine for me on SDK 9.0.3.GA. This fix shipped in 8.2.1.GA so please make sure you're using the correct SDK

@KamalKant-Tech
Copy link

Thats working. Sorry I did not update it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants