fix(ios): sf symbol handling for application shortcut

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-27394

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 3899 tests are passing. (There are 475 skipped tests not included in that total)
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against f56e152

[janvennemann]

Suggested change

	#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000
	#if IS_SDK_IOS_13

I feel a little uncomfortable only wrapping the image creation in the iOS 13 condition. Sure, this code block should never be reached when not built with iOS 13 SDK but only wrapping that single line inside it calls for unexpected behavior in the following lines, e.g. when module developers use TiBlob and wrongfully use initWithSystemImage:.

[vijaysingh-axway]

Agree. Wrapped whole function inside macro.

Macro IS_SDK_IOS_13 will not be available inside TitaniumKit framework.

[janvennemann]

Ah damn, i keep forgetting that the macro is for our other source files only. Maybe we should define the same macro in TitaniumKit as well, so we have some consistency across our source files.

[ssekhri]

FR Passed. An image blob is shown as part fo the app shortcut. Also no error is shown when adding the shortcut.
Verified on:
Mac OS 10.14.6
Ti SDK: 8.3.0.v20190923105712
Appc CLI: 7.1.1
Node: 10.5.0
JDK: 10.0.2
XCode: 11.0
Studio: 5.1.4.201909061933
Device: iPhone X(v13.0)