Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): volume event handling #11227

Merged
merged 2 commits into from Sep 20, 2019
Merged

fix(ios): volume event handling #11227

merged 2 commits into from Sep 20, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.0 milestone Sep 17, 2019
@build build requested a review from a team September 17, 2019 23:14
@build
Copy link
Contributor

build commented Sep 17, 2019 •
edited

Warnings
⚠️ This PR has milestone set to 8.2.0, but the version defined in package.json is 8.2.1 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against b68880b

@keerthi1032
Copy link
Contributor

FR passed.Volume event triggered and printed in console on pressing volume button.

Test Environment:
Operating System
Name = Mac OS X
Version = 10.14.6
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.3.0.v20190913171045 and 8.2.0.v20190917160001
Device -iPhone XR iOS 13.1,iphone x iOS 13,iphone 6s iOS 12

@keerthi1032 keerthi1032 merged commit 6d4e417 into tidev:8_2_X Sep 20, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Sep 25, 2019
@rlustemberg
Merge branch '8_2_X' into 8_2_X_INZDR
e70b5de 
* 8_2_X:
  fix(ios): properly set tint-color on image-view (tidev#11233)
  fix(ios)(8_2_X): sf symbol handling for application shortcut (tidev#11222)
  fix(ios): volume event handling (tidev#11227)
  fix(ios): also lookup semnantic colors in correct location for classic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @keerthi1032 @janvennemann