New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): select a valid ios sim xcodebuild destination #11228
Conversation
Dependencies with modified semantic versioning:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a similar crash as Jenkins is locally, changing the code as commented appears to fix the crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@cb1kenobi when trying to run a classic project on iOS 13 simulator, using XCode 11, I get the following error in both studio and cli
|
@ssekhri I don't believe it. Did you download the CI build or build from source? If from source, did you do an |
@cb1kenobi I got the build from the CI. Got the builds again from Jenkins for master and 8_2_X PRs and ensured that the ioslib version is 1.7.14. Same results with SDk builds from both the branch. |
@cb1kenobi tested the PR further. Noticed couple fo scenarios.
Issue 2:
Step 3: Again try to build the project to iOS simulator 12.2. On the second attempt the project build successfully to the 12.2 sim. |
FR Passed. Concurrent builds on iOS simulator work fine. Apart from couple of scenarios that seem to be specific to one system the iOS simulator builds work fine. |
The desired iOS simulator's runtime may be associated with a different Xcode than the one building with, so simply pick any simulator that is compatible with the Xcode building the app since it won't matter when ioslib laucnhes the selected iOS Simulator.
The desired iOS simulator's runtime may be associated with a different Xcode than the one building with, so simply pick any simulator that is compatible with the Xcode building the app since it won't matter when ioslib laucnhes the selected iOS Simulator.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27338