Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): select a valid ios sim xcodebuild destination [backport] #11235

Merged
merged 5 commits into from Oct 9, 2019
Merged

fix(ios): select a valid ios sim xcodebuild destination [backport] #11235

merged 5 commits into from Oct 9, 2019

Conversation

cb1kenobi
Copy link
Contributor

The desired iOS simulator's runtime may be associated with a different Xcode than the one building with, so simply pick any simulator that is compatible with the Xcode building the app since it won't matter when ioslib laucnhes the selected iOS Simulator.

JIRA: https://jira.appcelerator.org/browse/TIMOB-27338

The desired iOS simulator's runtime may be associated with a different Xcode than the one building with, so simply pick any simulator that is compatible with the Xcode building the app since it won't matter when ioslib laucnhes the selected iOS Simulator.
@build build added this to the 8.2.1 milestone Sep 23, 2019
@build
Copy link
Contributor

build commented Sep 23, 2019

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.13 to ^1.7.14

Generated by 🚫 dangerJS against f48aa77

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ssekhri
Copy link

ssekhri commented Oct 7, 2019

FR Passed. Concurrent builds on iOS simulator work fine.
Verified On:
Mac OS: 10.14.5
SDK: 8.2.1.v20190924075705
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0, 10.3
Device: iOS simulator 13.0, 12.4, 12.2

@lokeshchdhry lokeshchdhry merged commit 65cd2e5 into tidev:8_2_X Oct 9, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27338_8_2_X branch October 10, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants