Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): guard source property and removed NSNull if it is nil #11242

Merged
merged 5 commits into from Oct 3, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Sep 25, 2019
@build build requested a review from a team September 25, 2019 21:24
@build
Copy link
Contributor

build commented Sep 25, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4040 tests are passing.
(There are 475 skipped tests not included in that total)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 9ccecc9

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssaddique
Copy link
Contributor

FR Failed undefined still showing as before

Tested using the test apps (First and Second) and test steps mentioned here

See screenshot below

Screenshot 2019-10-02 at 15 52 56

Test Environment

MacOS Mojave 10.14.6
Xcode 11
Node 10.16.3
iPhone 11 Pro Sim(13.0)
{"NPM":"4.2.15","CLI":"7.1.1"}

@lokeshchdhry
Copy link
Contributor

@Expergefactor , Did you use :

Ti.App.iOS.addEventListener("handleurl", function () {
	alert("Second app on resume from url : " + Ti.App.getArguments().url);
});

In your alloy.js in both apps ?

@ssaddique
Copy link
Contributor

ssaddique commented Oct 3, 2019

@Expergefactor , Did you use :

Ti.App.iOS.addEventListener("handleurl", function () {
	alert("Second app on resume from url : " + Ti.App.getArguments().url);
});

In your alloy.js in both apps ?

I have used the updated code in both apps. I can confirm that the updated code works.

FR Passed

@sgtcoolguy sgtcoolguy merged commit 80cb018 into tidev:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants