Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): support new property to remove note #11247

Merged
merged 3 commits into from Oct 4, 2019
Merged

chore(ios): support new property to remove note #11247

merged 3 commits into from Oct 4, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Sep 27, 2019
@build build requested review from a team September 27, 2019 21:26
@build
Copy link
Contributor

build commented Sep 27, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4120 tests are passing.
(There are 469 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against f128bc5

sgtcoolguy
sgtcoolguy approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on #11248

@ssekhri
Copy link

ssekhri commented Oct 4, 2019

FR Passed
Fetching of contacts works without error when Ti.Contacts.includeNote is set to false.
Verified On:
Mac OS: 10.14.5
SDK: 8.3.0.v20190927141443
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iPhone X(13.0), iPhone 7Plus(12.3.1)

@ssekhri ssekhri merged commit 7891f3e into tidev:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy