TIMOB-6928 Android: Don't clobber existing modules when loading binding json file... #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles. The android module appears in to files: android.json and calendar.json. The latter was 'winning', so the binding layer knew nothing about PendingIntent, Notification,etc.
|
Code reviewed and functionally tested. Ran drillbit on v8/rhino. Request Accepted |
|
Functional testing passed V8/rhino. ACCEPTED |
|
Code reviewed. ACCEPTED |
ayeung
pushed a commit
that referenced
this pull request
Jan 9, 2012
TIMOB-6928 Android: Don't clobber existing modules when loading binding json file...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...s. The android module appears in two files: android.json and calendar.json. The latter was 'winning', so the binding layer knew nothing about PendingIntent, Notification,etc.
http://jira.appcelerator.org/browse/TIMOB-6928
The failcase is in the ticket. When you run it, you should be able to click the button and then see a notification in the notification area.
Please test rhino & v8, as this is stuff at the binding layer for both. Because the binding layer is touched significantly by this, please run drillbit for both runtimes.