Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): add single/doubletap to scrollview TIMOB-13286 #11251

Merged
merged 1 commit into from Dec 10, 2019

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Sep 30, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-13286

example code

    var win = Ti.UI.createWindow({
        backgroundColor: 'white'
    });
    var scrollview = Ti.UI.createScrollView({
        layout: 'vertical',
        height: '90%',
        contentWidth: 'auto',
        contentHeight: 'auto',
        showVerticalScrollIndicator: true,
        touchEnabled: true,
        backgroundColor: 'red'
    });

    win.add(scrollview);
    scrollview.addEventListener('click', function() {
        console.log('click');
    });

    scrollview.addEventListener('singletap', function() {
        console.log('single tap occured');
    });

    scrollview.addEventListener('doubletap', function() {
        console.log('doubletap tap occured');
    });

    win.open();

@m1ga m1ga changed the title fix (Android) Add single/doubletap to scrollview TIMOB-13286 fix(android) Add single/doubletap to scrollview TIMOB-13286 Sep 30, 2019
@m1ga m1ga changed the title fix(android) Add single/doubletap to scrollview TIMOB-13286 fix(android): add single/doubletap to scrollview TIMOB-13286 Sep 30, 2019
@build build added this to the 8.3.0 milestone Sep 30, 2019
@build build requested a review from a team September 30, 2019 23:21
@build
Copy link
Contributor

build commented Sep 30, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6653 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 888bab3

@sgtcoolguy sgtcoolguy removed this from the 8.3.0 milestone Dec 10, 2019
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FR pass. I updated the commit message to match conventions. Once build passes I'll merge it in.

@sgtcoolguy sgtcoolguy added this to the 9.0.0 milestone Dec 10, 2019
@sgtcoolguy sgtcoolguy merged commit 0326b7e into tidev:master Dec 10, 2019
@m1ga m1ga deleted the singleTap branch March 3, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants