Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): update log strings TIMOB-7786 #11252

Merged
merged 3 commits into from Oct 8, 2019
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Sep 30, 2019

JIRA:
https://jira.appcelerator.org/browse/TIMOB-7786

Summary:
Fixing typos in Log.


Test:

  1. Build and run the below on Android.
  2. Verify that the exception message reads "decodeNumber", not "encodeNumber", as shown below.
    Error: source was not specified for decodeNumber

app.js

var encodedValue = 123456;
var buffer = Ti.createBuffer({ length: 4 });
Ti.Codec.encodeNumber({
	source: encodedValue,
	dest: buffer,
	type: Ti.Codec.TYPE_INT,
})
var decodedValue = Ti.Codec.decodeNumber({
//	source: buffer,
	type: Ti.Codec.TYPE_INT,
});
alert("Encoded Value: " + encodedValue + "\nDecoded Value: " + decodedValue);

@m1ga m1ga changed the title fix(android) Update log strings TIMOB-7786 fix(android): update log strings TIMOB-7786 Sep 30, 2019
@build build added this to the 8.3.0 milestone Sep 30, 2019
@build build requested a review from a team September 30, 2019 23:19
@build
Copy link
Contributor

build commented Sep 30, 2019

Warnings
⚠️

Commit 701bf0d942215885fcccee66ca8c2584d4cd1352 has a message "fix(android) Update log strings TIMOB-7786" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖

✅ All tests are passing
Nice one! All 4120 tests are passing.
(There are 469 skipped tests not included in that total)

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 52409cc

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssaddique
Copy link
Contributor

FR: Passed

Test Environment
Studio Ver: 5.1.4.201909061933
SDK Ver: 8.3.0 (PR: 11252)
OS Ver: 10.14.6
Appc CLI: 7.1.1
Ti CLI Ver: 5.2.1
Node Ver: 10.16.3
NPM Ver: 6.11.3
Emulator: ⇨ Android 9 (Pixel 3 API 28)

Output

/app.js:8
var decodedValue = Ti.Codec.decodeNumber({

Error: source was not specified for decodeNumber

@ewanharris ewanharris merged commit 1fc77a1 into tidev:master Oct 8, 2019
@m1ga m1ga deleted the codecmodule branch March 3, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants