Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditions): Change from ifdef to if due to variable always being defined #11255

Merged
merged 2 commits into from Oct 3, 2019

Conversation

Sajoha
Copy link

@Sajoha Sajoha commented Oct 2, 2019

The test for whether or not we're using iOS 13 was using an ifdef condition, but this is always
defined as either true or false in the Titanium_Prefix.pch

https://jira.appcelerator.org/browse/TIMOB-27435

… defined

The test for whether or not we're using iOS 13 was using an ifdef condition, but this is always
defined as either true or false in the Titanium_Prefix.pch
@build build added this to the 8.2.1 milestone Oct 2, 2019
@build build requested a review from a team October 2, 2019 13:48
@build
Copy link
Contributor

build commented Oct 2, 2019

Warnings
⚠️

Commit 80dadf1d89603a5baa320bda48bb09b56880eb1b has a message "fix(conditions): Change from ifdef to if due to variable always being defined

The test for whether or not we're using iOS 13 was using an ifdef condition, but this is always
defined as either true or false in the Titanium_Prefix.pch" giving 2 errors:

  • header must not be longer than 72 characters, current length is 77
  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

✅ All tests are passing
Nice one! All 2239 tests are passing.
(There are 227 tests skipped)

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 0dee4c8

@sgtcoolguy sgtcoolguy added the bug label Oct 2, 2019
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy
Copy link
Contributor

QE: Please just mark as FR passed or not and tag me and I will squash merge this once it's ready (and cherry-pick to master)

@ssekhri
Copy link

ssekhri commented Oct 2, 2019

FR Passed.
Project builds successfully on 12.2 and 12.4 simulators with XCode 10.3 and iOS 12.2 and 13.0 simulators with XCode 11.
Verified on:
Mac OS: 10.14.5
SDK: 8.2.1.v20191002063548
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 10.3, 11.0
Device: iOS simulator v12.2, 12.4, 13.0

@ssekhri
Copy link

ssekhri commented Oct 2, 2019

@sgtcoolguy Kindly merge the PR and cherry-pick to master

@vijaysingh-axway
Copy link
Contributor

@sgtcoolguy Kindly merge the PR and cherry-pick to master

@ssekhri Here you go PR #11258

@sgtcoolguy sgtcoolguy merged commit ca3f3e3 into tidev:8_2_X Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants