Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): close window handling from presentationController’s delegate method #11256

Merged
merged 2 commits into from Oct 3, 2019
Merged

fix(ios): close window handling from presentationController’s delegate method #11256

merged 2 commits into from Oct 3, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 2, 2019
@build build requested a review from a team October 2, 2019 22:41
@build
Copy link
Contributor

build commented Oct 2, 2019 •
edited

Warnings
⚠️

Commit 31f21e40fb514ad77fec5019e66f8c32d1ea6971 has a message "fix(ios): close window handling from presentationController’s delegate method" giving 1 errors:

  • header must not be longer than 72 characters, current length is 77
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4120 tests are passing.
(There are 469 skipped tests not included in that total)
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 1fed4e3

sgtcoolguy
sgtcoolguy approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssekhri
Copy link

ssekhri commented Oct 3, 2019

FR Passed.
Verified On:
Mac OS: 10.14.5
SDK: 8.3.0.v20191002152729
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iPhone X(13.0)

@ssekhri ssekhri merged commit 40154d7 into tidev:master Oct 3, 2019
@hansemannn
Copy link
Collaborator

This caused a regression where modal windows cannot be presented fullscreen anymore.

hansemannn added a commit to hansemannn/titanium_mobile that referenced this pull request Oct 8, 2019
@hansemannn
Revert "fix(ios): close window handling from presentationController’s…
ad8341e 
… delegate method (tidev#11256)"

This reverts commit 40154d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @ssekhri @hansemannn @sgtcoolguy