Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditions): Change from ifdef to if due to variable always being defined #11258

Merged
merged 1 commit into from Oct 2, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Oct 2, 2019

Warnings
⚠️

Commit af42841f3d6141bb3fc165ed48239c9c9998c70e has a message "fix(conditions): Change from ifdef to if due to variable always being defined" giving 2 errors:

  • header must not be longer than 72 characters, current length is 77
  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4040 tests are passing.
(There are 475 skipped tests not included in that total)

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against af42841

@ssekhri
Copy link

ssekhri commented Oct 2, 2019

FR Passed.
Project builds successfully on 12.2 and 12.4 simulators with XCode 10.3 and iOS 12.2 and 13.0 simulators with XCode 11.
Verified on:
Mac OS: 10.14.5
SDK: 8.3.0.v20191002162335
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 10.3, 11.0
Device: iOS simulator v12.2, 12.4, 13.0

@ssekhri ssekhri merged commit da45e5f into tidev:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants