fix(ios): can not show fullscreen modal windows anymore #11267

vijaysingh-axway · 2019-10-08T22:23:15Z

https://jira.appcelerator.org/browse/TIMOB-27453

build · 2019-10-08T22:51:26Z

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	❌ 9 tests have failed There are 9 tests failing and 469 skipped out of 4591 total tests.
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

Classname	Name	Time	Error
ios.Titanium.UI.Layout	TIMOB-23372 #10	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1792:33
ios.Titanium.UI.Layout	TIMOB-23372 #9	0.001	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1762:33
ios.Titanium.UI.Layout	TIMOB-23372 #8	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1732:33
ios.Titanium.UI.Layout	TIMOB-23372 #7	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1699:33
ios.Titanium.UI.Layout	TIMOB-23372 #6	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1654:33
ios.Titanium.UI.Layout	TIMOB-23372 #5	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1609:33
ios.Titanium.UI.Layout	TIMOB-23372 #4	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1566:33
ios.Titanium.UI.Layout	TIMOB-23372 #3	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1522:33
ios.Titanium.UI.Layout	TIMOB-23372 #2	0.002	Error: expected 9 to equal 10 fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/node_modules/should/cjs/should.js:356:23 listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/A830085C-6CB7-4B3D-A871-81AD93AC3FAC/mocha.app/ti.ui.layout.test.js:1477:33

Generated by 🚫 dangerJS against d479081

ssekhri · 2019-10-10T22:17:38Z

FR Passed. Modal windows shown properly as per the style.
Verified on:
Mac OS: 10.14.5
SDK: 8.3.0.v20191010111000
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iPhone X(13.0), iPhone 7Plus(12.3.1)

fix(ios): can not show fullscreen modal windows anymore

5be9829

build added this to the 8.3.0 milestone Oct 8, 2019

build requested a review from a team October 8, 2019 22:51

build added ios needs tests 🚨 labels Oct 8, 2019

fix(ios): can not show fullscreen modal windows anymore

c4b275d

vijaysingh-axway added no tests and removed needs tests 🚨 labels Oct 9, 2019

vijaysingh-axway and others added 3 commits October 10, 2019 10:40

fix(ios): can not show fullscreen modal windows anymore

83d668c

Merge branch 'master' into TIMOb-27453

e236a38

fix(ios): can not show fullscreen modal windows anymore

84dd00d

ssekhri and others added 3 commits October 10, 2019 16:22

Merge branch 'master' into TIMOb-27453

701f153

fix(ios): can not show fullscreen modal windows anymore

993be1e

Merge branch 'master' into TIMOb-27453

8d77f19

janvennemann approved these changes Oct 12, 2019

View reviewed changes

build added the in-qe-testing 🕵 label Oct 12, 2019

Merge branch 'master' into TIMOb-27453

d479081

sgtcoolguy merged commit 1e3d161 into tidev:master Oct 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ios): can not show fullscreen modal windows anymore #11267

fix(ios): can not show fullscreen modal windows anymore #11267

vijaysingh-axway commented Oct 8, 2019

build commented Oct 8, 2019 •

edited

ssekhri commented Oct 10, 2019

fix(ios): can not show fullscreen modal windows anymore #11267

fix(ios): can not show fullscreen modal windows anymore #11267

Conversation

vijaysingh-axway commented Oct 8, 2019

build commented Oct 8, 2019 • edited

Tests:

ssekhri commented Oct 10, 2019

build commented Oct 8, 2019 •

edited