Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS)(8_2_X): can not show fullscreen modal windows anymore #11268

Merged
merged 10 commits into from Oct 14, 2019
Merged

fix(iOS)(8_2_X): can not show fullscreen modal windows anymore #11268

merged 10 commits into from Oct 14, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Oct 8, 2019 •
edited

@build build added this to the 8.2.1 milestone Oct 8, 2019
@build build requested a review from a team October 8, 2019 22:45
@build
Copy link
Contributor

build commented Oct 8, 2019 •
edited

Warnings
⚠️

Commit 8797c6dd38ed8fe64002bec70c2fb3072f30225c has a message "fix(ios): close window handling from presentationController’s delegate method" giving 1 errors:

  • header must not be longer than 72 characters, current length is 77
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4298 tests are passing.
(There are 471 tests skipped)
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 92e79ac

hansemannn
hansemannn reviewed Oct 9, 2019
View reviewed changes
iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewController.m Outdated
UIModalPresentationStyle style = [(id<TiWindowProtocol>)_proxy adaptivePresentationStyleForPresentationController:controller];
return style;
}
return UIModalPresentationNone;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be UIModalPresentationAutomatic for iOS 13+ and UIModalPresentationNone for < iOS 13 as per documentation.

janvennemann
janvennemann requested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Hans' comment, change the return value based on the iOS version. The rest looks good to me.

@vijaysingh-axway
Copy link
Contributor Author

As per Hans' comment, change the return value based on the iOS version. The rest looks good to me.

Updated!

@ssekhri
Copy link

ssekhri commented Oct 9, 2019

Found an issue with the latest build for this PR. On iOS device with version < 13 the style FORMSHEET shows up as FULLSCREEN. The difference is visible in landscape.
Use the test code from https://jira.appcelerator.org/browse/TIMOB-27453?focusedCommentId=451904&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-451904

@ssekhri
Copy link

ssekhri commented Oct 10, 2019

FR Passed. Modal windows shown properly as per the style.
Verified on:
Mac OS: 10.14.5
SDK: 8.2.1.v20191010153806
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iPhone X(13.0), iPhone 7Plus(12.3.1)

@sgtcoolguy sgtcoolguy merged commit a341c1b into tidev:8_2_X Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn left review comments

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
ios no tests
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vijaysingh-axway @build @ssekhri @janvennemann @hansemannn @sgtcoolguy