You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional Description:
Updates the Objective-C module template with the most recent default clang settings from Xcode 11. This includes CLANG_ENABLE_MODULES=YES which is required for compatibility with TitaniumKit, since it contains module imports. The Swift template already contains these settings.
Also bumps the deployment target to 9.0, to match our app project template.
@janvennemann with this PR the clang setting to Enable Modules (C and Objective-C) in xcode project for the module does gets set to Yes by default. However following the test instructions and test code mentioned in the ticket https://jira.appcelerator.org/browse/TIMOB-27410 we still do get the same error with both Xcode 10.3 and 11.1.
@ssekhri did you update the sample module? Also make sure to update the modules titanium.xcconfig, since they use a hardcoded value for the TITANIUM_SDK path.
FR Passed. The clang setting to Enable Modules (C and Objective-C) is set to Yes by default. The module builds successfully.
Verified on:
Mac OS: 10.14.5
SDK: 8.3.0.v20191016042241
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27410
Optional Description:
Updates the Objective-C module template with the most recent default clang settings from Xcode 11. This includes
CLANG_ENABLE_MODULES=YESwhich is required for compatibility with TitaniumKit, since it contains module imports. The Swift template already contains these settings.Also bumps the deployment target to 9.0, to match our app project template.