Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): target api level 29 by default #11284

Merged
merged 2 commits into from Oct 16, 2019
Merged

feat(android): target api level 29 by default #11284

merged 2 commits into from Oct 16, 2019

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26951

Summary:
Titanium builds now "targets" Android Q by default, if installed on the machine.

Test:

  1. Create a classic project.
  2. Build for Android.
  3. Open "Finder" or "Windows Explorer" and go to your project folder.
  4. Go to subdirectory: ./build/android
  5. Open file "AndroidManifest.xml".
  6. Verify XML attribute android:targetSdkVersion is set to 29.

@jquick-axway jquick-axway added this to the 8.3.0 milestone Oct 16, 2019
garymathews
garymathews approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build
Copy link
Contributor

build commented Oct 16, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4403 tests are passing.
(There are 479 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 1fb8cd2

@ssekhri
Copy link

ssekhri commented Oct 16, 2019

FR passed. API level 29 is used as the default target.
Verified on:
Verified On:
Mac OS: 10.14.5
SDK: 8.3.0.v20191016134404
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933

@garymathews garymathews merged commit 4d73a63 into tidev:master Oct 16, 2019
drauggres pushed a commit to drauggres/titanium_mobile that referenced this pull request Jul 23, 2023
@jquick-axway @drauggres
feat(android): target api level 29 by default (tidev#11284)
5debe16 
(cherry picked from commit 4d73a63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @ssekhri @garymathews