Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): wkwebview is stripping out = characters in cookies #11286

Merged
merged 4 commits into from Oct 30, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 17, 2019
@build build requested a review from a team October 17, 2019 00:23
@build
Copy link
Contributor

build commented Oct 17, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

✅ All tests are passing
Nice one! All 141 tests are passing.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 80ed13b

@ssjsamir ssjsamir self-requested a review October 24, 2019 14:13
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see = characters in cookies. Tested with the following test case:

const win = Ti.UI.createWindow({
backgroundColor: 'red'
});
var webView = Ti.UI.createWebView({
top: 0,
height: 200,
url: 'https://hnestmann-inside-eu01-dw.demandware.net/on/demandware.store/Sites-RefArch-Site/en_US/CookieCheck-Set'
});
win.add(webView);
 
var webView2 = Ti.UI.createWebView({
top: 250,
height: 200
});
win.add(webView);
 
webView.addEventListener('load', function(e){
webView2.url = 'https://hnestmann-inside-eu01-dw.demandware.net/on/demandware.store/Sites-RefArch-Site/en_US/CookieCheck-Check'
webView2.reload();
});
win.add(webView2);
win.open();

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11 
Node.js 10.16.3
iPhone 7 Sim(12.2).
{"NPM":"4.2.15-1","CLI":"7.1.1"}

@sgtcoolguy sgtcoolguy merged commit 1bd852b into tidev:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants