Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): setting last index of TabbedBar doesn't work #11288

Merged
merged 4 commits into from Oct 30, 2019
Merged

fix(ios): setting last index of TabbedBar doesn't work #11288

merged 4 commits into from Oct 30, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 17, 2019
@build build requested a review from a team October 17, 2019 21:47
@build
Copy link
Contributor

build commented Oct 17, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 2 tests have failed There are 2 tests failing and 247 skipped out of 2437 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.MediatakeScreenshot4.909
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:4326:18)
android.emulator.Titanium.UI.WebViewbaseURL should be accessible via window.location5.249
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:4326:18)

Generated by 🚫 dangerJS against 14f2bac

janvennemann
janvennemann approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@ssekhri
Copy link

ssekhri commented Oct 28, 2019

FR Passed. Last index of tabbed bar gets set when done after initialization.
Verified on:
Mac OS: 10.14.5
SDK: 8.3.0.v20191017142047
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.1
Device: iPhone XR(v13.1), iPhone 7Plus(v12.3.1), iOS simulator 13.1, 13.0, 12.2

@sgtcoolguy sgtcoolguy merged commit afb2a49 into tidev:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @ssekhri @janvennemann @sgtcoolguy