Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): set dest to generic iOS sim [TIMOB-27488] #11291

Merged
merged 2 commits into from Oct 23, 2019
Merged

fix(ios): set dest to generic iOS sim [TIMOB-27488] #11291

merged 2 commits into from Oct 23, 2019

Conversation

cb1kenobi
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27488

Removed auto-selected xcodebuild destination that was being too greedy with destination optimization.

@build build added this to the 8.2.1 milestone Oct 22, 2019
@build
Copy link
Contributor

build commented Oct 22, 2019 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

✅ All tests are passing
Nice one! All 2058 tests are passing.
(There are 243 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against bd490cd

ewanharris
ewanharris approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR pass!

Quickly tested building to different sim versions across different xcodes and it looks to handle that fine

@ssekhri
Copy link

ssekhri commented Oct 23, 2019 •
edited

FR Passed. Tab icons shown on iOS simulators
Verified On:
Mac OS: 10.14.5
SDK: 8.2.1.v20191023105841
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0, 10.3, 10.2.1
Device: iPhone X (v13.0), iPhone 7Plus (v12.3.1), iOS simulator version 13.0, 12.4, 12.2, 11.4, 9.3

@sgtcoolguy sgtcoolguy merged commit 5ffd747 into tidev:8_2_X Oct 23, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27488_8_2_X branch October 23, 2019 19:47
leehyeondeok pushed a commit to NableCommunications/titanium_mobile_nable that referenced this pull request Nov 8, 2019
@cb1kenobi @leehyeondeok
fix(ios): set dest to generic iOS sim (tidev#11291)
2d67347 
Fixes TIMOB-27488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug cli 📟 in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cb1kenobi @build @ssekhri @ewanharris @sgtcoolguy @lokeshchdhry