Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(npm): updated ioslib@1.7.16 [TIMOB-27490] #11293

Merged
merged 2 commits into from Oct 22, 2019
Merged

chore(npm): updated ioslib@1.7.16 [TIMOB-27490] #11293

merged 2 commits into from Oct 22, 2019

Conversation

cb1kenobi
Copy link
Contributor

@build build added this to the 8.2.1 milestone Oct 22, 2019
@build
Copy link
Contributor

build commented Oct 22, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.15 to ^1.7.17

Generated by 🚫 dangerJS against 2b13686

ewanharris
ewanharris approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 comes after 15. CR pass!

@ssekhri
Copy link

ssekhri commented Oct 22, 2019

FR Passed. Build to iOS device and sims successful. Build works fine in case of multiple XCode versions as well that have different sim runtimes installed.
Verified on:
Mac OS: 10.14.5
SDK: 8.2.1.v20191022133619
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0, 10.3, 10.2.1
Device: iPhone X(13.0), iOS simulator version 13.0, 12.4, 12.2, 11.4, 9.3

@ssekhri ssekhri merged commit 3e2c0a0 into tidev:8_2_X Oct 22, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27490_8_2_X branch October 23, 2019 14:45
leehyeondeok pushed a commit to NableCommunications/titanium_mobile_nable that referenced this pull request Nov 8, 2019
@cb1kenobi @leehyeondeok
chore(npm): updated ioslib@1.7.16 [TIMOB-27490] (tidev#11293)
ea1df46 
* chore(npm): updated ioslib@1.7.16 [TIMOB-27490]

* chore(npm): updated ioslib@1.7.17 [TIMOB-27490]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug cli 📟 in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cb1kenobi @build @ssekhri @ewanharris @sgtcoolguy