feat(android): Update V8 to 7.8.279.23 #11294

sgtcoolguy · 2019-10-22T19:11:33Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-27178

Description:
This is a work in progress to update to the latest V8 builds we can. Current Android SDK is on top of V8 7.3.492.26.

This PR currently updates us to V8 7.8.279.23
Current stable android v8 is 7.8.279.23 via https://omahaproxy.appspot.com

What I did:

Attempted to maintain backwards compatibility for APIs that modules may use in the appcelerator/v8_titanium builds
Update any V8 API usages in titanium_mobile to use the newer APIs and drop removed/deprecated API usages (including in the module template)
Cleaned up some of the templates/c++ code to try and remove unnecessary headers includes (to hopefully speed up builds of the SDK a little)
Commit c4aa037 includes a minor performance patch - it moves attempting to load "core" (read: native) modules after handling requires starting with '/' or '.'. When I turned on some debug logging in the c++ code, I saw that it kept trying to load bindings for '.'. This does mean that technically we'd "lose" the ability to load native modules starting with a '.', but I'm not even sure we allow that in module id naming.
(Note that I also noticed a bug in the building of the require path used for add-on tests in the test suite where it was trying to load add-on test files with no '/' prefix, so it hit the "core" module code path and failed)

build · 2019-10-22T19:26:34Z

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 6676 tests are passing. (There are 700 skipped tests not included in that total)

New dependencies added: request-promise-native.

request-promise-native

Author: Nicolai Kamenzky

Description: The simplified HTTP request client 'request' with Promise support. Powered by native ES6 promises.

Homepage: https://github.com/request/request-promise-native#readme


Created	over 3 years ago
Last Updated	about 1 month ago
License	ISC
Maintainers	2
Releases	10
Direct Dependencies	`request-promise-core`, `stealthy-require` and `tough-cookie`
Keywords	xhr, http, https, promise, request, then, thenable and native

README

Request-Promise-Native

This package is similar to request-promise but uses native ES6+ promises.

Please refer to the request-promise documentation. Everything applies to request-promise-native except the following:

Instead of using Bluebird promises this library uses native ES6+ promises.
Native ES6+ promises may have fewer features than Bluebird promises do. In particular, the .finally(...) method was not included until Node v10.

Installation

This module is installed via npm:

npm install --save request
npm install --save request-promise-native

request is defined as a peer-dependency and thus has to be installed separately.

Migration from `request-promise` to `request-promise-native`

Go through the migration instructions to upgrade to request-promise v4.
Ensure that you don't use Bluebird-specific features on the promise returned by your request calls. In particular, you can't use .finally(...) anymore.
You are done.

Contributing

To set up your development environment:

clone the repo to your desktop,
in the shell cd to the main folder,
hit npm install,
hit npm install gulp -g if you haven't installed gulp globally yet, and
run gulp dev. (Or run node ./node_modules/.bin/gulp dev if you don't want to install gulp globally.)

gulp dev watches all source files and if you save some changes it will lint the code and execute all tests. The test coverage report can be viewed from ./coverage/lcov-report/index.html.

If you want to debug a test you should use gulp test-without-coverage to run all tests without obscuring the code by the test coverage instrumentation.

Change History

v1.0.8 (2019-11-03)
- Security fix: bumped request-promise-core which bumps lodash to ^4.17.15. See vulnerabilty reports.
  (Thanks to @aw-davidson for reporting this in issue #49.)
v1.0.7 (2019-02-14)
- Corrected mistakenly set tough-cookie version, now ^2.3.3
  (Thanks to @evocateur for pointing this out.)
- If you installed request-promise-native@1.0.6 please make sure after the upgrade that request and request-promise-native use the same physical copy of tough-cookie.
v1.0.6 (2019-02-14)
- Using stricter tough-cookie@~2.3.3 to avoid installing tough-cookie@3 which introduces breaking changes
  (Thanks to @jasonmit for pull request #33)
- Security fix: bumped lodash to ^4.17.11, see vulnerabilty reports
v1.0.5 (2017-09-22)
- Upgraded tough-cookie to a version without regex DoS vulnerability
  (Thanks to @sophieklm for pull request #13)
v1.0.4 (2017-05-07)
- Fix that allows to use tough-cookie for cookie creation
v1.0.3 (2016-08-08)
- Renamed internally used package @request/promise-core to request-promise-core because there where too many issues with the scoped package name
v1.0.2 (2016-07-18)
- Fix for using with module bundlers like Webpack and Browserify
v1.0.1 (2016-07-17)
- Fixed @request/promise-core version for safer versioning
v1.0.0 (2016-07-15)
- Initial version similar to request-promise v4

License (ISC)

In case you never heard about the ISC license it is functionally equivalent to the MIT license.

See the LICENSE file for details.

Generated by 🚫 dangerJS against df6866e

android/runtime/v8/src/native/modules/ScriptsModule.cpp

CreateDefaultPlatform() was deprecated and removed by v8

don't attempt to load core module if request begins with '.' or '/'

garymathews · 2019-11-27T23:40:42Z

Updated to latest V8 version 7.8.279.23 which is patched to be fully backwards compatible with Titanium SDK 7.0.0+ native modules
Updated various V8 API usages to the latest revisions

… pr-11294

package.json

jquick-axway · 2019-12-09T20:09:27Z

android/runtime/v8/src/native/TypeConverter.cpp

@@ -239,7 +240,7 @@ jobject TypeConverter::jsObjectToJavaFunction(Isolate* isolate, JNIEnv *env, Loc
 {
 	Local<Function> func = jsObject.As<Function>();
 	Persistent<Function, CopyablePersistentTraits<Function>> jsFunction(isolate, func);
-	jsFunction.MarkIndependent();
+	// jsFunction.MarkIndependent(); // Method has been removed!


Do we need to do anything here?

If this is where we box anonymous JS callbacks, then we shouldn't make it a weak reference since it might get garbage collected before invoked on the Java side.

I think this is okay, it looks like we store a persistent reference to the JS function so it can't be garbage collected and release the reference when the Java function is destroyed Java_org_appcelerator_kroll_runtime_v8_V8Function_nativeRelease

jquick-axway · 2019-12-09T20:41:41Z

build/lib/android/snapshot.js

-	// Set correct permissions for 'mksnapshot'
-	await fs.chmod(MKSNAPSHOT_PATH, 0o755);
+		// Obtain snapshot `id` and start new snapshot generation.
+		const id = await request.post(SNAPSHOT_URL, { body: { v8, script }, json: true });


If you don't have Internet access, then the await request.post() will reject and throw an exception. Perhaps we should catch it, log the reject's error, and continue without the snapshot?

Although for Jenkins builds of our SDK (namely release builds), we don't want this behavior.

We're catching the exception here, so this shouldn't be an issue.

jquick-axway

CR: Pass

lokeshchdhry · 2019-12-10T18:51:34Z

FR Passed.

Checked liveview, kitchensink & native modules 7.0.0+.

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.0.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.2.1
Appc NPM: 5.0.0-2
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Devices: ⇨ google Pixel (Android 10)

lokeshchdhry · 2019-12-10T20:00:26Z

Can someone please resolve the conflict.

sgtcoolguy added android improvement work in progress 🚧 no tests labels Oct 22, 2019

build added this to the 8.3.0 milestone Oct 22, 2019

build added the needs jira 🚨 label Oct 22, 2019

garymathews reviewed Oct 22, 2019

View reviewed changes

android/runtime/v8/src/native/modules/ScriptsModule.cpp Show resolved Hide resolved

sgtcoolguy changed the title ~~feat(android): Update V8 to 7.4.288.28~~ feat(android): Update V8 to 7.8.279.19 Oct 31, 2019

sgtcoolguy added 10 commits October 31, 2019 11:57

fix(android): call NewDefaultPlatform(), not CreateDefaultPlatform()

bc25e70

CreateDefaultPlatform() was deprecated and removed by v8

feat(android): point to v8 7.4 build

fb18915

fix(android): adapt to new GetOwnPropertyNames() GetPropertyNames() APIs

e9b50cd

fix(android): update v8 checksum

46c942a

build: initial cpmpiling version against V8 7.8

d324ab7

build(android): avoid unecessary header includes

0d4cf6b

build(android): update v8 build and checksum for 7.8

dfc5504

perf(android): move attempts to load core modules after checking prefix

c4aa037

don't attempt to load core module if request begins with '.' or '/'

build(android): add debug logging, update v8 api usage

d8cdfbb

build(android): add debug logging, update v8 api usage

e1dff39

sgtcoolguy force-pushed the v8-7.4 branch from e9f8c2d to e1dff39 Compare October 31, 2019 15:58

sgtcoolguy modified the milestones: 8.3.0, 9.0.0 Oct 31, 2019

sgtcoolguy and others added 4 commits November 7, 2019 10:52

Merge branch 'master' into v8-7.4

a562e46

fix(android): update to newer V8 apis

4042f06

fix(android): update v8 version to 7.8.279.23

7e38017

Merge branch 'master' into v8-7.4

97ec190

garymathews changed the title ~~feat(android): Update V8 to 7.8.279.19~~ feat(android): Update V8 to 7.8.279.23 Nov 27, 2019

garymathews and others added 2 commits December 2, 2019 11:03

Merge branch 'master' into v8-7.4

ca7af1a

Merge branch 'master' of github.com:appcelerator/titanium_mobile into…

6a094f6

… pr-11294

garymathews force-pushed the v8-7.4 branch from 7f1d572 to 2cbe5c0 Compare December 6, 2019 00:21

chore(android): implement remote snapshot generation

03cb177

garymathews force-pushed the v8-7.4 branch from 037b995 to 03cb177 Compare December 7, 2019 02:51

garymathews marked this pull request as ready for review December 7, 2019 03:57

garymathews removed the work in progress 🚧 label Dec 7, 2019

sgtcoolguy requested review from ypbnv and jquick-axway December 9, 2019 16:35

garymathews added 2 commits December 9, 2019 08:44

fix(android): update snapshot processing status code

cf43908

Merge branch 'master' into v8-7.4

9109c54

sgtcoolguy commented Dec 9, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

Gary Mathews and others added 3 commits December 9, 2019 10:29

fix(android): mark request-promise-native as devDependency

91e08c1

Merge branch 'master' into v8-7.4

58ac8d3

Merge branch 'master' into v8-7.4

08cf4a4

jquick-axway reviewed Dec 9, 2019

View reviewed changes

Merge branch 'master' into v8-7.4

99c46fd

garymathews mentioned this pull request Dec 9, 2019

chore(android): include x86_64 in module template #11384

Merged

jquick-axway approved these changes Dec 9, 2019

View reviewed changes

build added in-qe-testing 🕵 and removed needs jira 🚨 labels Dec 9, 2019

garymathews mentioned this pull request Dec 9, 2019

fix(android): specify default inspector context #11375

Merged

ssaddique and others added 2 commits December 10, 2019 10:38

Merge branch 'master' into v8-7.4

0e0f3ce

Merge branch 'master' into v8-7.4

caa9d7b

Merge branch 'master' into v8-7.4

1660ddf

build added the merge conflicts 🚨 label Dec 10, 2019

Merge branch 'master' into v8-7.4

df6866e

garymathews removed the merge conflicts 🚨 label Dec 10, 2019

lokeshchdhry merged commit 9006b4d into tidev:master Dec 11, 2019

sgtcoolguy deleted the v8-7.4 branch December 11, 2019 19:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(android): Update V8 to 7.8.279.23 #11294

feat(android): Update V8 to 7.8.279.23 #11294

sgtcoolguy commented Oct 22, 2019 •

edited by garymathews

build commented Oct 22, 2019 •

edited

Request-Promise-Native

Installation

Migration from `request-promise` to `request-promise-native`

Contributing

Change History

License (ISC)

garymathews commented Nov 27, 2019

jquick-axway Dec 9, 2019

garymathews Dec 9, 2019

jquick-axway Dec 9, 2019

garymathews Dec 9, 2019 •

edited

jquick-axway left a comment

lokeshchdhry commented Dec 10, 2019

lokeshchdhry commented Dec 10, 2019

feat(android): Update V8 to 7.8.279.23 #11294

feat(android): Update V8 to 7.8.279.23 #11294

Conversation

sgtcoolguy commented Oct 22, 2019 • edited by garymathews

build commented Oct 22, 2019 • edited

request-promise-native

Request-Promise-Native

Installation

Migration from request-promise to request-promise-native

Contributing

Change History

License (ISC)

garymathews commented Nov 27, 2019

jquick-axway Dec 9, 2019

Choose a reason for hiding this comment

garymathews Dec 9, 2019

Choose a reason for hiding this comment

jquick-axway Dec 9, 2019

Choose a reason for hiding this comment

garymathews Dec 9, 2019 • edited

Choose a reason for hiding this comment

jquick-axway left a comment

Choose a reason for hiding this comment

lokeshchdhry commented Dec 10, 2019

lokeshchdhry commented Dec 10, 2019

sgtcoolguy commented Oct 22, 2019 •

edited by garymathews

build commented Oct 22, 2019 •

edited

Migration from `request-promise` to `request-promise-native`

garymathews Dec 9, 2019 •

edited