Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): updated to ioslib@1.17.8 [TIMOB-27338] #11296

Merged
merged 1 commit into from Oct 25, 2019
Merged

chore(npm): updated to ioslib@1.17.8 [TIMOB-27338] #11296

merged 1 commit into from Oct 25, 2019

Conversation

cb1kenobi
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 24, 2019
@build
Copy link
Contributor

build commented Oct 24, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 2 tests have failed There are 2 tests failing and 479 skipped out of 4886 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.WebViewbaseURL should be accessible via window.location0.814
Error: expected '"https://www.google.com/"' to equal 'https://www.google.com/'
at Assertion.fail (/node_modules/should/cjs/should.js:275:17)
      at Assertion.value (/node_modules/should/cjs/should.js:356:19)
      at WebView.<anonymous> (/ti.ui.webview.addontest.js:26:29)
ios.Titanium.UI.WebViewbaseURL should be accessible via window.location2.003
Error: timeout of 2000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/2589D817-D6C9-4AAB-ABDB-8C8068955919/data/Containers/Bundle/Application/C6DF7145-C0A5-45A8-B376-0C935982DC02/mocha.app/ti-mocha.js:4326:27

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.17 to ^1.7.18

Generated by 🚫 dangerJS against 4efe3b2

@ssekhri
Copy link

ssekhri commented Oct 24, 2019

FR passed.
Verified On:
Mac OS: 10.14.5
SDK: 8.3.0.v20191024150951
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iOS simulator 13.0, 12.2

@sgtcoolguy sgtcoolguy merged commit 25536c4 into tidev:master Oct 25, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27338 branch October 25, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants