New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): ipad popover crash #11303
fix(ios): ipad popover crash #11303
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@janvennemann Can we add sample code to the test suite that used to trigger the crash? I understand we don't currently run tests on an iPad, but I suspect we may eventually add that to Jenkins. |
FR Passed. Popover on iPad does not crash and work fine. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27503
Prevents changing the presentation controller's delegate for iPad popovers. It's set to the popover proxy by default which does all the required setup before showing the popover.