Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update ti.cloak to include linux binaries #11306

Merged
merged 3 commits into from Nov 1, 2019
Merged

chore: update ti.cloak to include linux binaries #11306

merged 3 commits into from Nov 1, 2019

Conversation

garymathews
Copy link
Contributor

  • Update ti.cloak to include Linux binaries

JIRA Ticket

@garymathews garymathews added this to the 8.3.0 milestone Oct 30, 2019
@build
Copy link
Contributor

build commented Oct 30, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 1 tests have failed There are 1 tests failing and 247 skipped out of 2448 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.WebViewbaseURL should be accessible via window.location8.001
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 70f6692

@garymathews garymathews force-pushed the TIMOB-27514 branch 3 times, most recently from ed9286a to 5b23802 Compare October 30, 2019 23:38
@build build requested a review from a team October 30, 2019 23:39
@build build added the android label Oct 30, 2019
@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 5.1.4.201909061933
SDK Ver: 8.3.0 local build
Xcode Ver: Xcode 11.1
Appc NPM: 4.2.15
Appc CLI: 7.1.2-master.3
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.1
Node Ver: 12.13.0
NPM Ver: 6.12.0
Java Ver: 10.0.2
Android Devices: ⇨ google Pixel (Android 9)

sgtcoolguy
sgtcoolguy reviewed Nov 1, 2019
View reviewed changes
android/titanium/src/java/org/appcelerator/titanium/io/TiResourceFile.java
// Iterate through stream to obtain true size.
if (is instanceof CipherInputStream) {
long size = 0;
long read = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this should be an int, as #read() returns an int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot to amend this after switching from .skip()

@sgtcoolguy sgtcoolguy merged commit 1365850 into tidev:master Nov 1, 2019
@jquick-axway
Copy link
Contributor

@garymathews, did you remove the require('Buffer') (with a capital 'B') from the script that was causing module loading issues on case-sensitive filesystems?

@garymathews
Copy link
Contributor Author

@jquick-axway Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @jquick-axway @sgtcoolguy