New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): semantic colors with alpha value #11315
Conversation
b4349bd
to
56121db
Compare
|
c336b95
to
aeb5397
Compare
So I was a bit confused about this one, but there's a few points to mention:
I've fixed the merge conflicts and unified the code used both at runtime and during the app build. A When we return a value from Ti.UI.fetchSemanticColor on Android/older iOS - we return a |
Fixes TIMOB-27519
* force alpha as float in iOS Contents.json
test values with rgba hex, rgb hex, hex/alpha separated
JIRA: https://jira.appcelerator.org/browse/TIMOB-27519
Test case:
Resources/app.js
Resources/semantic.colors.json
```javascript { "green_100.0": { "light": { "color": "#00ff00", "alpha": "100.0" }, "dark": { "color": "#8000", "alpha": "100.0" } }, "blue_75.0": { "light": { "color": "#0000ff", "alpha": "75.0" }, "dark": { "color": "#80", "alpha": "75.0" } }, "cyan_50.0": { "light": { "color": "#00ffff", "alpha": "50.0" }, "dark": { "color": "#8080", "alpha": "50.0" } }, "red_25.0": { "light": { "color": "#ff0000", "alpha": "25.0" }, "dark": { "color": "#800000", "alpha": "25.0" } }, "magenta_0": { "light": { "color": "#ff00ff", "alpha": "0" }, "dark": { "color": "#800080", "alpha": "0.0" } }, "yellow_noalpha": { "light": "#ffff00", "dark": "#808000" } }