Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): setting last index of tabbedBar after initialization not work #11324

Merged
merged 2 commits into from Nov 12, 2019
Merged

fix(ios): setting last index of tabbedBar after initialization not work #11324

merged 2 commits into from Nov 12, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.0 milestone Nov 11, 2019
@build build requested a review from a team November 11, 2019 22:04
@build
Copy link
Contributor

build commented Nov 11, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 23 tests have failed There are 23 tests failing and 711 skipped out of 7334 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ListViewdeleteSectionAt60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewreplaceSectionAt60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewinsertSectionAt60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewappendSection60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewCustom template59.999
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewheaderView60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewsection header & footer60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Windowwindow_navigation2.518
Error: expected 0 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti.ui.window.test.js:732:8037
ios.ipad.Titanium.UI.WindowTIMOB-2060030.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Windowwindow_close_order_220.002
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Windowwindow_close_order_130
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Window#remove(View)20.002
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.TableViewTIMOB-26164 : updateRow + insertRowAfter causing crash on main thread5.001
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.TableViewDelete row (Search Active)5.002
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.TextFieldheight5.003
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.View.accessibility* Properties10.003
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Viewevent source and bubbles property10.001
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewurl(local)30.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewkeyboardDisplayRequiresUserAction30.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewurl30.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Window.eventsfocus event is fired when opened20.002
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Window.eventsblur event is fired when closed20.002
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.Utils#base64encode(Ti.Blob#TYPE_DATA from Ti.UI.View.toImage() async)5.002
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/93689104-4D5C-4810-90AB-1EAC77628D32/mocha.app/ti-mocha.js:6535:53348

Generated by 🚫 dangerJS against 7fd8fea

@ssekhri
Copy link

ssekhri commented Nov 12, 2019

FR Passed.
Verified on:
Mac OS: 10.14.5
SDK: 9.0.0.v20191111135450
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.2
Device: iPhone X(v13.2), iPhone 7Plus(v12.3.1), iOS simulator 13.2, 12.4

@sgtcoolguy sgtcoolguy merged commit 5fbe782 into tidev:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @ssekhri @janvennemann @sgtcoolguy