Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): tintColor not working for TabbedBar in iOS 13 #11329

Merged
merged 6 commits into from Dec 3, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Nov 13, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against c2b967b

@ssjsamir ssjsamir self-requested a review November 27, 2019 15:47
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see 'tintColor' not working for TabbedBar in iOS 13. Tested with the following test cases:
Test Case 1 (tinColor) -

const win = Ti.UI.createWindow({
backgroundColor: 'black'
});
var test = Ti.UI.createTabbedBar({
labels: [ '1', '2', '3', 'AUTO' ],
tintColor: 'red',
backgroundColor: 'yellow'
});
win.add(test);
win.open();

Test Case 2 (new properties) -

const win = Ti.UI.createWindow({
backgroundColor: 'black'
});
var test = Ti.UI.createTabbedBar({
labels: [ '1', '2', '3', 'AUTO' ],
backgroundColor: 'white',
textColor: 'red',
selectedTextColor: 'green',
selectedButtonColor: 'red',
});
win.add(test);
win.open();

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11
Node.js 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
iPhone 8 (ios 13.2)

@lokeshchdhry lokeshchdhry merged commit ec6fbf6 into tidev:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants