Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(node): drop node 8, support node 10.13+, node 12 #11336

Merged
merged 3 commits into from Nov 18, 2019
Merged

build(node): drop node 8, support node 10.13+, node 12 #11336

merged 3 commits into from Nov 18, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy
build(node): drop node 8, support node 10.13+, node 12
c2a9f0c 
BREAKING CHANGE: Removal of Node 8 support, move to Node 10.13+

Fixes TIMOB-27605
@sgtcoolguy
ci(jenkins): use node 10.17.0 to build/test
6060048
cb1kenobi
cb1kenobi approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@build build added this to the 9.0.0 milestone Nov 14, 2019
@build
Copy link
Contributor

build commented Nov 14, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6624 tests are passing.
(There are 710 skipped tests not included in that total)

Generated by 🚫 dangerJS against dfe2158

@cb1kenobi cb1kenobi merged commit f35cf0e into tidev:master Nov 18, 2019
@sgtcoolguy sgtcoolguy deleted the node-10 branch November 18, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @cb1kenobi