TIMOB-6811: Android: Media - blob.length exception: method not supported #1134
Conversation
|
Code review and functional test accepted. Easily reproduced failcase on device, then got a real value and no error when running with this branch. |
| } else { | ||
| fileSize = ((TiBaseFile) data).size(); | ||
| } | ||
| return (int) fileSize; |
There was a problem hiding this comment.
Will we ever need to return a value larger than int here? This may need to be a larger type and should also likely be unsigned.
|
Code reviewed; please address comments. |
|
Technically to support the full 64-bit long in getLength() we would need to change both the return type and other places that use it as well, which would probably be outside the scope of this issue. For practical purposes, we probably won't be dealing with Blobs / Files > 2GB in size for a while to come. Also, FWIW Java doesn't support unsigned types |
|
OK; that makes sense. We should just be trying to avoid downcasting, but that would obviously require a lot of changes to either codebase. Code reviewed, APPROVED. |
|
Functional tested, Android emulator Google API Rev 8 (Froyo) w/HVGA w/Camera w/GPS w/SDCard. Passed. APPROVED. |
|
Confirmed the image size via adb shell. Going to push the button. |
TIMOB-6811: Android: Media - blob.length exception: method not supported
http://jira.appcelerator.org/browse/TIMOB-6811
Test steps in Jira