fix(ios): updated behaviour to original

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-27350

[build]

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 2377 tests are passing. (There are 228 skipped tests not included in that total)

Generated by 🚫 dangerJS against 045ea94

[sgtcoolguy]

LGTM

[sgtcoolguy]

Generally LGTM, but then I dug deeper...

I think we could fairly easily automate a test for this. Originally my understanding was that a Ti.Blob's toString() method returned it's text value. But I did not consider binary blobs.

So my guess here for the behavior is that if the Blob contains text, toString() should return that, and if it contains binary bytes, it should return "[object TiBlob]" . In fact, this is exactly what Android's implementation attempts to do.

And in further looking, iOS's TiBlob has a description method that more or less does the same thing. That appears to be how "old" proxies handled toString() on IOS.

So I think we need to:

• Remove the TiBlob.m description method
• Add this JS-based fix as you have it
• add some unit tests for TiBlob that test when:
  • the blob has empty string content
  • the blob has ascii/text content
  • the blob has binary content

[vijaysingh-axway]

@sgtcoolguy

1. Method "description" is used internally. It is not exposed to developers. It is overridden from NSObject to log proper data while using Ti.API. See here. When [newArray componentsJoinedByString:@" "] get called, it looks fro description of every object inside newArray. I think we should not remove it.
2. Unit tests added.

[sgtcoolguy]

There's no need for this hook as none of the tests open a window...

[sgtcoolguy]

LGTM, pushed modified commits to have messages match convention and remove the unnecessary test hook. Tests kind of do FR for QE, but should probably double-check with the original ticket's use case.

[ssjsamir]

FR Passed: Tested using the the test case mentioned in https://jira.appcelerator.org/browse/TIMOB-27350 able to see data received as a blon
[INFO] �� � Received Data: [object TiBlob]

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11.3
Node.js 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
iPhone 8 (ios 13.3)