Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android): remove Ti.UI.WebView.onStopBlacklistedUrl event #11361

Merged
merged 4 commits into from Dec 9, 2019
Merged

refactor(android): remove Ti.UI.WebView.onStopBlacklistedUrl event #11361

merged 4 commits into from Dec 9, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Nov 21, 2019 •
edited

JIRA https://jira.appcelerator.org/browse/TIMOB-27618

Description:
Removes an android-specific event in favor of a cross-platform version. This event has been deprecated since 6.1.0.

Found when looking at #11352 (thanks @drauggres !)

@sgtcoolguy
refactor(webview): remove onStopBlacklistedUrl event
8766df8 
BREAKING CHANGE: The event was deprecated in SDK 6.1.0 and is now removed in 9.0.0. Please use
blacklisturl event instead
@sgtcoolguy
docs(webview): mark onStopBlacklistedUrl event as removed in 9.0.0
86dacef
@sgtcoolguy sgtcoolguy requested a review from a team November 21, 2019 16:50
@build build added this to the 9.0.0 milestone Nov 21, 2019
@build build requested a review from a team November 21, 2019 17:11
@build
Copy link
Contributor

build commented Nov 21, 2019 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6676 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 9500937

@sgtcoolguy sgtcoolguy changed the title Remove onStopBlacklistedUrl refactor(android): remove Ti.UI.WebView.onStopBlacklistedUrl event Nov 21, 2019
ypbnv
ypbnv approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.0.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.2.1
Appc NPM: 5.0.0-2
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Devices: ⇨ google Pixel (Android 10)

@lokeshchdhry lokeshchdhry merged commit 85b32d8 into tidev:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android BREAKING CHANGES ⚠️ docs in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @build @lokeshchdhry @ypbnv