New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): support font scaling for custom fonts #11364
Conversation
Tests:
|
|
||
Notes: | ||
Since SDK 9.0.0 property <Font.fontFamily> will not be ignored for iOS 11+. | ||
Custom fonts can be used with this property for dynamic font management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads like a bug fix release note so i don't think it should be part of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to tell developer that this behavior is available to use for iOS 11+. So I think there should be something in doc to tell this otherwise how developer will know. That's why I put in Notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i agree that we have to make this changes public somewhere. And for that i think the release notes are a better place. So users now right away, ok that was fixed in 9.0.0.
A note in the docs saying that the property works as expected with the current SDK seems unnecessary. There should have been a note in the docs for previous SDK versions saying that the property does not work as expected, which we would have removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading this in context again i'm fine with the message how it is. IMHO still not ideal though, but that's an issue of our docs not being versioned.
FR Passed. |
https://jira.appcelerator.org/browse/TIMOB-25847