Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): support font scaling for custom fonts #11364

Merged
merged 3 commits into from Dec 18, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.0 milestone Nov 22, 2019
@build build requested review from a team November 22, 2019 19:20
@build build added the docs label Nov 22, 2019
@build
Copy link
Contributor

build commented Nov 22, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 244 skipped out of 2451 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Apppause/resume events (9)9.009
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
android.emulator.Titanium.Network.HTTPClientclearCookieUnaffectedCheck (9)60.005
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 7f4c96d


Notes:
Since SDK 9.0.0 property <Font.fontFamily> will not be ignored for iOS 11+.
Custom fonts can be used with this property for dynamic font management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads like a bug fix release note so i don't think it should be part of the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to tell developer that this behavior is available to use for iOS 11+. So I think there should be something in doc to tell this otherwise how developer will know. That's why I put in Notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i agree that we have to make this changes public somewhere. And for that i think the release notes are a better place. So users now right away, ok that was fixed in 9.0.0.

A note in the docs saying that the property works as expected with the current SDK seems unnecessary. There should have been a note in the docs for previous SDK versions saying that the property does not work as expected, which we would have removed now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading this in context again i'm fine with the message how it is. IMHO still not ideal though, but that's an issue of our docs not being versioned.

@ssekhri
Copy link

ssekhri commented Dec 16, 2019

FR Passed.
Verified on:
Mac OS: 10.15.1
SDK: 9.0.0.v20191216133819
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Studio: 6.0.0.201911251516
Xcode: 11.2
Device: iPhone Xr(v13.2.2)

@sgtcoolguy sgtcoolguy merged commit 8045620 into tidev:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants