Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup APIs #11368

Merged
merged 24 commits into from Dec 9, 2019
Merged

Cleanup APIs #11368

merged 24 commits into from Dec 9, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Nov 26, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27617

Description:
Now that we have nice npm scripts to see what's deprecated in our APIs but not removed (See #11366), it gave me a good list of things to look over. This PR is a work in progress to remove those long-deprecated APIs (or fix up our docs to update when they actually did get removed).

The commit messages detail the exact APIs I'm working with, but I'll try to summarize here:

  • Ti.UI.CoverFlowView was removed in 6.0.0 (moved under iOS namespace)
  • Ti.UI.AdView was removed in 7.0.0 (basically the create method was around and just logged a message)
  • Ti.UI.Android.LINKIFY_* constants were removed here for 9.0.0 (use Ti.UI.AUTOLINK_* constants)
  • Ti.Stream callbacks' errorState and errorDescription properties were removed here for 9.0.0 (use code and error properties)
  • Ti.Network.Socket.TCP error callback errorCode property was removed here for 9.0.0 (use code)
  • Ti.UI.WebView error event errorCode and message properties were removed here for 9.0.0 (use code and error)
  • Ti.UI.iPad.Popover properties height, width, leftNavButton and rightNavButton were removed (the nav buttons were actually removed at time of deprecation in 3.4.2)
  • Ti.UI.Window android:* events are removed here for 9.0.0 (replaced by equivalent without colon in 3.0.0)
  • Ti.Media.cameraAuthorizationStatus was removed here for 9.0.0 (replaced by Ti.Media.cameraAuthorization in 5.2.0)
  • Ti.Media. AUDIO_SESSION_MODE_SOLO_AMBIENT was actually removed in 6.0.0
  • Ti.Media. AUDIO_SPEAKER was actually removed in 3.6.0
  • Ti.Media.recordinginput and Ti.Media.linechange events were actually removed in 3.5.1
  • Ti.UI.View's startLayout(), updateLayout() and finishLayout() methods are removed here for 9.0.0 (deprecated since 3.0.0)
  • Ti.UI.iOS.BLEND_MODE_* constants are removed here for 9.0.0 (replaced by equivalents in Ti.UI namespace in 7.3.0)

@build
Copy link
Contributor

build commented Nov 26, 2019

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 0cc644e

BREAKING CHANGE: Removes the LINKIFY_* constants living in Android namespace taht have been
deprecated since SDK 3.0.0
This removes the errorState and errorDescription properties that have been deprecated since sdk
3.0.0

BREAKING CHANGE: Removes deprecated stream callback properties
    This removes the errorState and errorDescription properties that have been deprecated since sdk
    3.0.0

    BREAKING CHANGE: Removes deprecated stream callback properties
Marks the errorState and errorDescription properties on stream callbacks removed in SDK 9.0.0 that have been deprecated since 3.0.0
    This removes the errorCode property that has been deprecated since sdk
    3.1.0

    BREAKING CHANGE: Removes deprecated tcp error callback errorCode property
    This removes the errorCode property that has been deprecated since sdk
    3.1.0

    BREAKING CHANGE: Removes deprecated tcp error callback errorCode property
Marks the errorCode property on tcp error callbacks removed in SDK 9.0.0 that have been deprecated since 3.1.0
    This removes the errorCode and message properties that have been deprecated since sdk
    3.1.0

    BREAKING CHANGE: Removes deprecated webview error event properties: errorCode and message
Marks the errorCode and message properties on webview error events removed in SDK 9.0.0 that have been deprecated since 3.1.0
    This removes the height, width, leftNavButton and rightNavButton properties that have been deprecated since sdk
    3.4.2

    BREAKING CHANGE: Removes deprecated ipad popover properties: height, width, leftNavButton and rightNavButton
Marks the height, width, leftNavButton and rightNavButton properties on
popover removed in SDK 9.0.0 that have been deprecated since 3.4.2.
Note that some of them were effectively removed at time of deprecation.
BREAKING CHANGES: removes deprecated Ti.UI.Window.android:* events
BREAKING CHANGES: removes deprecated Ti.Media.cameraAuthorizationStatus property
@sgtcoolguy
Copy link
Contributor Author

Relates to #11362

@sgtcoolguy sgtcoolguy marked this pull request as ready for review December 9, 2019 15:28
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android changes look good to me!

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed for iOS.

@sgtcoolguy sgtcoolguy merged commit f9ac67c into tidev:master Dec 9, 2019
@sgtcoolguy sgtcoolguy deleted the cleanup-apis branch December 9, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants