fix(android): fix setting DatePicker's minDate\maxDate

[ypbnv]

JIRA: https://jira.appcelerator.org/browse/TIMOB-27625

Description:
Fix for setting min\max Date for Date type of Ti.UI.Picker. Some code optimization. Adding accessors
for the properties. There was a scenario where the value was not matching what the Picker was showing, so in order to avoid that now the getter is returning what the native component is showing.
Thus the unit tests that would cover such an attempt.

About DatePickerProxy - would that be a leftover class ? I don't see support for Ti.UI.createDatePicker on Android side and I think we can remove the file.

Test case:
app.js

var maxDate = new Date();
 
var window = Ti.UI.createWindow({
    layout: "vertical",
    backgroundColor: "#454441"
});
var picker = Ti.UI.createPicker({
     type: Ti.UI.PICKER_TYPE_DATE,
     maxDate: maxDate
});
window.add(picker);
var button = Ti.UI.createButton({
    title: "Set Max Date"
});
button.addEventListener("click", function() {
    picker.maxDate = new Date(maxDate.getFullYear() + 1, maxDate.getMonth(), maxDate.getDate());
});
window.add(button);
window.open();

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	❌ 6 tests have failed There are 6 tests failing and 472 skipped out of 4601 total tests.

Tests:

Classname	Name	Time	Error
android.emulator.fs	#readFile() returns String when utf-8 encoding set via options object argument (9)	2.062	Error: timeout of 2000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.fs	#readFile() returns String when utf-8 encoding set via second argument (9)	2.051	Error: timeout of 2000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.fs	#readFile() returns Buffer when no encoding set (9)	2.106	Error: timeout of 2000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.Media.AudioPlayer	#restart (9)	7.936	Error: timeout of 5000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.Media.AudioPlayer	#start, #stop (9)	5.43	Error: timeout of 5000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.WebView	userAgent (9)	30.003	Error: timeout of 30000ms exceeded at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 91f30f9

[ypbnv]

I believe the minDate test fails due to a typo in it. It was undetected so far because minDate did not have a getter providing the value directly from the native picker component.

[sgtcoolguy]

This doesn't account for Time pickers. I know Android doesn't support Date + Time pickers for now, but for a Time picker, I think this should likely return the Date object equivalent to "today" at the selected time of the picker.

[sgtcoolguy]

Also, not the point of this PR, but why don't we have a Date + Time picker on Android? I mean we support each individually. Why can't we just create a component that includes both (and merges the date and time value into a single Date object?). Maybe this is a good job to do at the JS level, overriding the createPicker method to handle that specific case and have it silently delegate to both pickers under the hood?

[jquick-axway]

I agree that we should our own custom Date+Time picker.
I've written a feature request for it here: TIMOB-27840

[sgtcoolguy]

might want to "clean up" (close) the window after the test like the other UI test suites do.

[sgtcoolguy]

Related, the useSpinner property has been deprecated since 5.2.1, I think we can remove the property and the extra code we have around it here. (TiUITimeSpinner, TiUIDateSpinner, TiUISpinner)

[jquick-axway]

@sgtcoolguy, I don't think we should remove the "useSpinner" feature and perhaps consider un-deprecating it. This is because some app devs like using it.

If you follow the link below, the reason it was deprecated was because there used to be a bug where the spinner's content would not line-up with the other columns correctly. Instead of fixing it, the feature was deprecated and we told devs to use the drop-down picker instead.
https://jira.appcelerator.org/browse/TIMOB-17998

But we fixed the spinner's bug in 7.3.0. So, I think we should keep it now. :)
https://jira.appcelerator.org/browse/TIMOB-19822

[jquick-axway]

I'm closing this PR in favor of PR #11621 which is focused more on the bug itself.
We can refactor things later.