Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): use correct target for transpiling on ios #11373

Merged
merged 3 commits into from Dec 3, 2019

Conversation

ewanharris
Copy link
Collaborator

@ewanharris ewanharris commented Dec 2, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27630

this.minSupportedIosSdk is for the supported iOS SDK's not the supported iOS versions for an app

Relates to #11343

this.minSupportedIosSdk is for the supported iOS SDK's not the supported iOS versions for an app

Fixes TIMOB-27630
@build
Copy link
Contributor

build commented Dec 2, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against 882e399

@ssekhri
Copy link

ssekhri commented Dec 3, 2019

FR Passed.
Mac OS: 10.15.1
SDK: 9.0.0.v20191202063422
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Studio: 5.1.4.201909061933
Xcode: 11.2
Device: iPad Mini(v9.3), iOS simulator 13.2, 12.4, 11.2

@ssekhri ssekhri merged commit c4a998a into tidev:master Dec 3, 2019
@ewanharris ewanharris deleted the TIMOB-27630 branch January 7, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants