Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): proper macro used for wrapping code #11389

Merged
merged 2 commits into from Dec 11, 2019
Merged

fix(ios): proper macro used for wrapping code #11389

merged 2 commits into from Dec 11, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

sgtcoolguy
sgtcoolguy approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy added this to the 9.0.0 milestone Dec 11, 2019
@build
Copy link
Contributor

build commented Dec 11, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6677 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 91bb51b

@ssekhri
Copy link

ssekhri commented Dec 11, 2019

FR Passed.
Project builds successfully to iOS device and simulator.
Verified on:
Mac OS: 10.15.1
SDK: 9.0.0.v20191211135012
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Studio: 6.0.0.201911251516
Xcode: 11.2
Device: iPhone X(v13.2), iPhone 7Plus(v12.3.1), iOS simulator 13.2

@ssekhri ssekhri merged commit 5bb63c5 into tidev:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy