Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modules): remove deprecated modules #11390

Merged
merged 2 commits into from Dec 13, 2019
Merged

chore(modules): remove deprecated modules #11390

merged 2 commits into from Dec 13, 2019

Conversation

ewanharris
Copy link
Collaborator

BREAKING CHANGE: Removes ti.touchid and ti.safaridialog from the SDK distribution

Closes TIMOB-27650

@ewanharris
chore(modules): remove deprecated modules
eee1a8c 
BREAKING CHANGE: Removes ti.touchid and ti.safaridialog from the SDK distribution

Closes TIMOB-27650
@sgtcoolguy sgtcoolguy added this to the 9.0.0 milestone Dec 12, 2019
sgtcoolguy
sgtcoolguy approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These modules have been deprecated and replace by newer modules we ship. If users need to continue using them, they can keep using the globally installed versions from previous SDK installs - or grab the zips from the modules' Github releases.

@build
Copy link
Contributor

build commented Dec 12, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 700 skipped out of 7377 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.WebViewuserAgent (9)48.462
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 5b486f6

@sgtcoolguy sgtcoolguy mentioned this pull request Dec 12, 2019
Closed
@sgtcoolguy sgtcoolguy merged commit 1dc178e into tidev:master Dec 13, 2019
@ewanharris ewanharris deleted the TIMOB-27650 branch January 15, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGES ⚠️ in-qe-testing 🕵
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @sgtcoolguy