Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(windows): fire analyzeJsFile hook for Windows" #11392

Closed
wants to merge 1 commit into from

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Dec 13, 2019

This reverts commit e6340c2.

JIRA: https://jira.appcelerator.org/browse/TIMOB-27601

This practically reverts #11334. Non-standard hook has been removed from hyperloop by tidev/hyperloop.next#328.

@infosia infosia added this to the 9.0.0 milestone Dec 13, 2019
@build
Copy link
Contributor

build commented Dec 13, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 700 skipped out of 7377 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Window.eventsclose event is fired (9)20.052
Error: timeout of 20000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 1c5864d

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Maybe it'd be best to update the hyperloop module alongside this to ensure that we keep it working?

@infosia
Copy link
Contributor Author

infosia commented Dec 17, 2019

@ewanharris Yes, I'm asking @janvennemann to release new version of hyperloop (v4.0.5) tidev/hyperloop.next#331 . Once it's done I'm going to update hyperloop module with this PR.

@ewanharris
Copy link
Collaborator

Superseded by #11413

@ewanharris ewanharris closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants