Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): prevent duplicate launch animation #11394

Merged
merged 1 commit into from Jan 2, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Dec 13, 2019

  • Prevent duplicate launch animation from occurring on cold-start
EXAMPLE

TEST CASE
  • Launch any Titanium application
  • Launch animation should not stutter

JIRA Ticket

@build
Copy link
Contributor

build commented Dec 13, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6691 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against deb0106

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM 👍

@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.0.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.2.1
Appc NPM: 5.0.0-2
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Devices: ⇨ google Pixel (Android 10)

@jquick-axway
Copy link
Contributor

This is really the same issue written here...
https://jira.appcelerator.org/browse/TIMOB-27328

I skirted the issue by switching to a fade-effect. But I think the downside of this PR removing the open animation is that if the app has a long startup time, then no open animation will occur when you open the 1st child window.

@lokeshchdhry, would you mind trying the below code. It blocks on app startup for 4 seconds before opening a window reading "Hello World". Verify that you see that an open-animation between the splash and the child window... because I think this PR has removed that animation.

function blockThread() {
	var endTime = new Date();
	endTime.setTime(endTime.getTime() + 4000);
	while (endTime >= new Date()) {}
}
blockThread();

var window = Ti.UI.createWindow();
window.add(Ti.UI.createLabel({ text: "Hello World!" }));
window.open();

@garymathews
Copy link
Contributor Author

@jquick-axway This shouldn't affect the animation of TiActivity windows. But I figured the fix should live in TiLaunchActivity instead (this won't affect the behavior of the fix). But you may want to re-test?

@lokeshchdhry
Copy link
Contributor

@garymathews , can you please fix the jenkins error of can't find symbol

[2019-12-20T00:40:13.940Z] [javac] 		if (TiApplication.firstOnActivityStack()) {
[2019-12-20T00:40:13.940Z]     [javac] 		                 ^
[2019-12-20T00:40:13.940Z]     [javac]   symbol:   method firstOnActivityStack()
[2019-12-20T00:40:13.940Z] [javac]   location: class TiApplication

@sgtcoolguy
Copy link
Contributor

Looks like the latest force push missed some code or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants