New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): prevent duplicate launch animation #11394
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR LGTM 👍
FR Passed. Studio Ver: 6.0.0.201911251516 |
This is really the same issue written here... I skirted the issue by switching to a fade-effect. But I think the downside of this PR removing the open animation is that if the app has a long startup time, then no open animation will occur when you open the 1st child window. @lokeshchdhry, would you mind trying the below code. It blocks on app startup for 4 seconds before opening a window reading "Hello World". Verify that you see that an open-animation between the splash and the child window... because I think this PR has removed that animation. function blockThread() {
var endTime = new Date();
endTime.setTime(endTime.getTime() + 4000);
while (endTime >= new Date()) {}
}
blockThread();
var window = Ti.UI.createWindow();
window.add(Ti.UI.createLabel({ text: "Hello World!" }));
window.open(); |
0cbe4b0
to
5a60707
Compare
@jquick-axway This shouldn't affect the animation of |
@garymathews , can you please fix the jenkins error of
|
Looks like the latest force push missed some code or something. |
5a60707
to
deb0106
Compare
EXAMPLE
TEST CASE
JIRA Ticket