Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): update v8 to 7.9.317.32 #11398

Merged
merged 2 commits into from Dec 17, 2019
Merged

chore(android): update v8 to 7.9.317.32 #11398

merged 2 commits into from Dec 17, 2019

Conversation

garymathews
Copy link
Contributor

  • Update V8 to latest stable version 7.9.317.32

JIRA Ticket

@garymathews garymathews added this to the 9.1.0 milestone Dec 16, 2019
@build
Copy link
Contributor

build commented Dec 16, 2019 •
edited

Warnings
⚠️ This PR has milestone set to 9.1.0, but the version defined in package.json is 9.0.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6680 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 43fa286

sgtcoolguy
sgtcoolguy approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build passed and all the tests passed as well. Not really sure what more we'd want to check before merging this in, but looks good to me.

@garymathews
Copy link
Contributor Author

@sgtcoolguy Maybe we could get this into 9.0.0?

@sgtcoolguy sgtcoolguy modified the milestones: 9.1.0, 9.0.0 Dec 17, 2019
@sgtcoolguy
Copy link
Contributor

@garymathews yeah, I don't see why not. The compatibility API patches didn't change, this doesn't break anything and all the tests passed fine.

@sgtcoolguy sgtcoolguy merged commit 946a098 into tidev:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @sgtcoolguy