fix(android): can't set versionCode in manifest as of 9.0.0 #11416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27705
Note 1:
This issue was never in a release version. Was caught before release.
Regression caused by changing build system from "ant" to "gradle".
Note 2:
Android gradle build system ignores "versionCode" and "versionName" set in "AndroidManfiest.xml". This is by Google's design. You are expected to set these settings in the "build.gradle" file instead. This PR maintains backward compatibility by reading these 2 version settings in the "tiapp.xml" and "./platform/android/AndroidManifest.xml" and writing them to the generated "build.gradle" file.
Note 3:
Titanium app developer can also set "versionCode" and "versionName" via their own "./platform/android/build.gradle" file. This will take priority over the Titanium generated "build.gradle" file.
Test:
./build/android/app/build/intermediates/merged_manifests/debug
android:versionCode
is set to5
../platform/android
../build/android/app/build/intermediates/merged_manifests/debug
android:versionCode
is set to7
.tiapp.xml
./platform/android/build.gradle
android { defaultConfig { versionCode 7 } }