feat: extend global console API to be more Node-compatible #11425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
janvennemann
requested changes
Jan 15, 2020
| if (options && options.apiName === 'Ti.API') { | ||
| this._apiModule = options; | ||
| } else { | ||
| // if (!options || typeof options.write === 'function') { |
There was a problem hiding this comment.
It might be good to spit out a warning / error here since this will practically create a broken console object which will lead to a crash when used due to _apiModule being undefined.
There was a problem hiding this comment.
I forgot to push my last 2 commits which implemented the stream codepath. Oops! Anyways, please re-check.
janvennemann
requested changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26572
Description:
This moves the
global.consoledefinition entirely into thecommonJS-layer so that it is defined in a cross-platform way. The removes the JS definition baked into Android's runtime JS, and removes the native Obj-c console on iOS.Our global console object receives the
Ti.APImodule (so that we can callinfo,warn,erroranddebugon it). Note that native logging and Ti.API have the concept of log levels, whereas node console really treats log/info/debug as just going tostdoutand warn/error as going tostderr. So we have to try and retain the log level notion when possible (we sniff for being constructed with an object that has a propertyapiName === 'Ti.API', which allows "hijacking" the actual underlying writes in JS tests to verify the strings passed along). It also supports NodeJs stream-like objects in the constructor (but then loses the log level concept - instead passing log/info/debug tostdoutand warn/error tostderr)Note that we don't have any real shim API for NodeJS streams yet, though (so I couldn't say test a console that actually wrapped a file stream to write to files).
Oh, an important thing to note as well: I did not try to implement
console.table(). It seemed... extensive.