Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): target Java8 and Kotlin support for native modules #11434

Merged
merged 3 commits into from Jan 23, 2020

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Jan 15, 2020

JIRA:

Description:
Targets Java 8 and adds support for Kotlin for developing native android modules.

Test case:

  1. Download ti.kotlin.zip attached to TIMOB-25896.
  2. Unzip it.
  3. Open the terminal.
  4. CD to directory: ./ti.kotlin/android
  5. Run: appc run -p android
  6. Above builds the module and builds/runs its "example" app.
  7. Verify example app shows a white background with a red square.
  8. Verify that you see the following messages in the log.
[INFO]   TiKotlinModule: (main) [0,106] @@@ Java8Interface.printMessage1() called.
[INFO]   Java8: (main) [0,106] @@@ Java8Interface.printMessage2() called.
[INFO]   ExampleProxy: (main) [3,109] @@@ Example creation property 'message' set to: Creating an example Proxy
[INFO]   ExampleProxy: (main) [0,109] @@@ Example.printMessage() called: Hello world!
[INFO]   ExampleProxy: (main) [0,109] @@@ Example.setMessage() called: Hi world!.  It's me again.
[INFO]   ExampleProxy: (main) [0,109] @@@ Example.printMessage() called: Hello world!

targets Java 8 and adds support for Kotlin for developing native android modules
@ypbnv ypbnv added this to the 9.0.0 milestone Jan 15, 2020
@build build requested a review from a team January 15, 2020 16:42
@build
Copy link
Contributor

build commented Jan 15, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 8 tests have failed There are 8 tests failing and 701 skipped out of 7250 total tests.

Tests:

ClassnameNameTimeError
android.emulator.fs#readFile() returns String when utf-8 encoding set via options object argument (9)2.021
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.fs#readFile() returns String when utf-8 encoding set via second argument (9)2.351
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.fs#readFile() returns Buffer when no encoding set (9)2.066
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.Android.ProgressIndicatordialog indeterminant - show in different windows (9)5.543
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.LayoutTIMOB-23372 #10 (9)21.622
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.LayoutTIMOB-23372 #6 (9)6.265
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (9)10.276
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.TabGroupadd Map.View to TabGroup (9)19.382
Error: timeout of 15000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)

Generated by 🚫 dangerJS against 803c2cb

@ypbnv
Copy link
Contributor Author

ypbnv commented Jan 16, 2020

@jquick-axway Updated.

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri
Copy link

ssekhri commented Jan 22, 2020

FR Passed. The test case for Java8 and Kotlin work as expected on both mac and windows OS.
Verified on:
Mac OS: 10.15.1, Win 10 Pro
SDK: 9.0.0.v20200122065826
Appc CLI: 7.1.2
JDK: 11.0.4, 1.8.0_162
Node: 10.16.3

@jquick-axway
Copy link
Contributor

@ypbnv, is the "Allow edits from maintainers" unchecked for this PR?
We're unable to "Update" it with "master".
(I don't have permission to update this PR from the command line either.)

@sgtcoolguy sgtcoolguy merged commit eef37a6 into tidev:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants