New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ios): removed custom asset image hashing #11437
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR'd the build changes and they look good to me. I have not performed a FR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native iOS changes are looking good as well!
FR Passed. Test environment: |
This was merged way too early, sorry guys. New regressions:
|
This was merged way too early, sorry guys. New regressions:
|
@hansemannn Can you provide test case please? @lokeshchdhry Can you verify with more test cases apart from mentioned in ticket. |
@vijaysingh-axway Interesting edge case actually. What if a user wants to use a raw image that shouldn't go to the asset catalog? It's definitely no show stopper, but may get back to the universal-asset-catalog-masterpiece from @cb1kenobi again 😛(happy birthday btw, man!) |
https://jira.appcelerator.org/browse/TIMOB-25032