fix(ios): handle uncaught exceptions in timers and Obj-C based proxy fireEvent lifecycle #11439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
changed the title
|
janvennemann
previously requested changes
Jan 22, 2020
iphone/TitaniumKit/TitaniumKit/Sources/Kroll/KrollTimerManager.m
Outdated
Show resolved
Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/Kroll/KrollTimerManager.m
Outdated
Show resolved
Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/Kroll/KrollTimerManager.m
Outdated
Show resolved
Hide resolved
Fixes TIMOB-27528
Fixes TIMOB-27528
sgtcoolguy
force-pushed
the
TIMOB-27528
branch
from
0f44091
to
bae7732
Compare
janvennemann
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27528
Description:
This adds some manual checking of unhandled exceptions after firing events or running timers using the new Obj-C JSC API. If there is an exception, we call out TiExceptionHandler code (i.e. display the grey/red stack trace view, fire Ti.App.uncaughtException event).
Note that last time we added an exception handler on the JSC API itself and that messed with the test suite working properly. I hope/assume this will not?