Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): added proper condtion to import MediaPlayer #11440

Merged
merged 4 commits into from Jan 31, 2020
Merged

fix(ios): added proper condtion to import MediaPlayer #11440

merged 4 commits into from Jan 31, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.0 milestone Jan 17, 2020
@build build requested a review from a team January 17, 2020 22:03
@build
Copy link
Contributor

build commented Jan 17, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6549 tests are passing.
(There are 701 skipped tests not included in that total)

Generated by 🚫 dangerJS against 14722f5

janvennemann
janvennemann approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssaddique ssaddique merged commit 3943012 into tidev:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vijaysingh-axway @build @janvennemann @ssaddique @lokeshchdhry @sgtcoolguy