New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): properly set ImageView tintColor #11441
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Looks good to me!
I've confirmed that this PR's code change makes Android's tint behave exactly like iOS' for both masked images and completely opaque images (such as camera photos). Side Note: |
@jquick-axway I made titanium-image-filters exactly for that :). Or you can use masked image filters that are available in the SDK as well. |
@garymathews The unit test failures seem unrelated, but maybe critical: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to see the tint applied to the following test case (https://jira.appcelerator.org/browse/TIMOB-27721) :
const window = Ti.UI.createWindow();
const icon = Ti.UI.createImageView({
tintColor: 'red',
width: 30,
image: 'example.png'
});
window.add(icon);
window.open();
Test Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel Xl 7.1.1 Sim
JIRA: https://jira.appcelerator.org/browse/TIMOB-27721